Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Improve consistency in getgateway.h #1045

Closed
wants to merge 1 commit into from
Closed

[Bugfix] Improve consistency in getgateway.h #1045

wants to merge 1 commit into from

Conversation

TzviPM
Copy link

@TzviPM TzviPM commented Aug 31, 2022 •
edited
Loading

Description

  • change the file name of getgateway.c to getgateway.m for consistency (Note*: all C is valid Objective C)
  • add include of <netinet/in.h> to getgateway.h as it contains definition for in_addr_h
    • Note: without this, if a build system tries to include getgateway.h before <netinet/in.h>, then in_addr_t will not be defined.

Related Issues

AFAIK, no explicit bugs exist for these changes

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated the version in pubspec.yaml and CHANGELOG.md.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@TzviPM TzviPM marked this pull request as ready for review August 31, 2022 16:49
@TzviPM TzviPM changed the title Main [Bugfix] Improve consistency in getgateway.h Aug 31, 2022
@TzviPM
Copy link
Author

TzviPM commented Sep 2, 2022

@miquelbeltran are you the right person to review this? I'm not sure how to request a review, but this PR should be ready for one.

The failing check for code coverage seems irrelevant in this case, since I didn't really add any new code per say.

@miquelbeltran
Copy link
Member

Thanks! Potentially is all good, but I need to build and run at least once before approving and merging.

@TzviPM
Copy link
Author

TzviPM commented Sep 4, 2022

I think this actually can't be merged as is. The getgateway.c file was copied from a stack overflow in 2015, which was released under a CC BY-SA 3.0 license.

Changing the file requires updating the header to specify that we made changes, linking to the license, and releasing our changes under the same license. I'm not sure how the current BSD license would have to be updated to exclude this file either.

I have asked the author if they would publish a github gist with the code and specify a more permissive license.

@miquelbeltran
Copy link
Member

Thanks for checking! I made a comment about removing the header, but then I realized that the header was in the original file, so I removed my comment. I'm fine to keep the header as it is, or add the changes as you say.

@TzviPM
Copy link
Author

TzviPM commented Sep 5, 2022

to better track this: https://stackoverflow.com/a/29440193/2679603

@TzviPM TzviPM mentioned this pull request Sep 6, 2022
Closed
@TzviPM
Copy link
Author

TzviPM commented Sep 6, 2022

Tracking issue: #1058. I will close this PR for now as it will not be mergeable with the current licensing issues.

@TzviPM TzviPM closed this Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TzviPM @miquelbeltran